[Ipmitool-devel] [ ipmitool-Bugs-3571570 ] delloem exec file won't handle more than one command

[D***@Emerson.com]

Hi all,

Styblik indicates via a comment yesterday that the patches I submitted last September for this issue will not be added to ipmitool saying " I'm afraid fix will be, well, complicated."

I believe the patches I sent were a complete fix. We have been using them since September without issue. We would much rather use ipmitool without patches rather than keep patches around that fix generic issues like this.

What else is required to get these changes into ipmitool?

Thanks,
Dick Detweiler

[Zdenek Styblik]

Post by D***@Emerson.com
Hi all,

Hello Dick,

Post by D***@Emerson.com
Styblik indicates via a comment yesterday that the patches I submitted last September for this issue will not be added to ipmitool saying " I'm afraid fix will be, well, complicated."

yep, that's what I said. However, I didn't say issue won't be fixed.

Post by D***@Emerson.com
I believe the patches I sent were a complete fix. We have been using them since September without issue.

Despite your patch does fix issue in question, there is no need to
"fix", or modify in any other way, 'src/ipmishell.c', because it isn't
broken. But 'lib/ipmi_delloem.c' apparently is.

Post by D***@Emerson.com
We would much rather use ipmitool without patches rather than keep patches around that fix generic issues like this.

If other modules were affected, that would be a generic issue. But it
seems to me they're not. So I would say it's a 'lib/ipmi_delloem.c'
issue.

Post by D***@Emerson.com
What else is required to get these changes into ipmitool?

Re-write 'lib/ipmi_delloem.c' a bit, resp. change the way it handles argc/argv.

Best regards,
Z.

Post by D***@Emerson.com
Thanks,
Dick Detweiler

[Zdenek Styblik]

On Wed, Mar 27, 2013 at 12:53 PM, Zdenek Styblik

Post by Zdenek Styblik

Post by D***@Emerson.com
Hi all,

Hello Dick,

Post by D***@Emerson.com
Styblik indicates via a comment yesterday that the patches I submitted last September for this issue will not be added to ipmitool saying " I'm afraid fix will be, well, complicated."

yep, that's what I said. However, I didn't say issue won't be fixed.

Post by D***@Emerson.com
I believe the patches I sent were a complete fix. We have been using them since September without issue.

Despite your patch does fix issue in question, there is no need to
"fix", or modify in any other way, 'src/ipmishell.c', because it isn't
broken. But 'lib/ipmi_delloem.c' apparently is.

Post by D***@Emerson.com
We would much rather use ipmitool without patches rather than keep patches around that fix generic issues like this.

If other modules were affected, that would be a generic issue. But it
seems to me they're not. So I would say it's a 'lib/ipmi_delloem.c'
issue.

Post by D***@Emerson.com
What else is required to get these changes into ipmitool?

Re-write 'lib/ipmi_delloem.c' a bit, resp. change the way it handles argc/argv.

You know what? If you have time and willing to try something out, try
to change following in 'lib/ipmi_delloem.c':
~~~
-static int current_arg = 0;
+int current_arg = 0;
~~~

And see whether it doesn't break normal operation of
'lib/ipmi_delloem.c' and whether it fixes your/reported issue as well.
That's the quickest/easiest fix that comes, resp. I had for some time,
in my mind. I obviously haven't tried it, but I would (eventually).

Z.

Post by Zdenek Styblik
Best regards,
Z.

Post by D***@Emerson.com
Thanks,
Dick Detweiler

[D***@Emerson.com]

OK - will let you know what we find.

Thanks Z,

Richard Detweiler | T 256-261-6550


-----Original Message-----
From: Zdenek Styblik [mailto:***@gmail.com]
Sent: Wednesday, March 27, 2013 7:07 AM
To: Detweiler, Dick [NETPWR/AVOCENT/AL]
Cc: ipmitool-***@lists.sourceforge.net
Subject: Re: [ ipmitool-Bugs-3571570 ] delloem exec file won't handle more than one command

Post by Zdenek Styblik

Post by D***@Emerson.com
Hi all,

Hello Dick,

Post by D***@Emerson.com
Styblik indicates via a comment yesterday that the patches I submitted last September for this issue will not be added to ipmitool saying " I'm afraid fix will be, well, complicated."

yep, that's what I said. However, I didn't say issue won't be fixed.

Post by D***@Emerson.com
I believe the patches I sent were a complete fix. We have been using them since September without issue.

Despite your patch does fix issue in question, there is no need to
"fix", or modify in any other way, 'src/ipmishell.c', because it isn't
broken. But 'lib/ipmi_delloem.c' apparently is.

Post by D***@Emerson.com
We would much rather use ipmitool without patches rather than keep patches around that fix generic issues like this.

If other modules were affected, that would be a generic issue. But it
seems to me they're not. So I would say it's a 'lib/ipmi_delloem.c'
issue.

Post by D***@Emerson.com
What else is required to get these changes into ipmitool?

Re-write 'lib/ipmi_delloem.c' a bit, resp. change the way it handles argc/argv.

You know what? If you have time and willing to try something out, try to change following in 'lib/ipmi_delloem.c':
~~~
-static int current_arg = 0;
+int current_arg = 0;
~~~

And see whether it doesn't break normal operation of 'lib/ipmi_delloem.c' and whether it fixes your/reported issue as well.
That's the quickest/easiest fix that comes, resp. I had for some time, in my mind. I obviously haven't tried it, but I would (eventually).

Z.

Post by Zdenek Styblik
Best regards,
Z.

Post by D***@Emerson.com
Thanks,

[Zdenek Styblik]

Post by D***@Emerson.com
OK - will let you know what we find.
Thanks Z,
Richard Detweiler | T 256-261-6550

Hello Richard,

any progress on this one?

Thanks,
Z.

Post by D***@Emerson.com
-----Original Message-----
Sent: Wednesday, March 27, 2013 7:07 AM
To: Detweiler, Dick [NETPWR/AVOCENT/AL]
Subject: Re: [ ipmitool-Bugs-3571570 ] delloem exec file won't handle more than one command

Post by Zdenek Styblik

Post by D***@Emerson.com
Hi all,

Hello Dick,

Post by D***@Emerson.com
Styblik indicates via a comment yesterday that the patches I submitted last September for this issue will not be added to ipmitool saying " I'm afraid fix will be, well, complicated."

yep, that's what I said. However, I didn't say issue won't be fixed.

Post by D***@Emerson.com
I believe the patches I sent were a complete fix. We have been using them since September without issue.

Despite your patch does fix issue in question, there is no need to
"fix", or modify in any other way, 'src/ipmishell.c', because it isn't
broken. But 'lib/ipmi_delloem.c' apparently is.

Post by D***@Emerson.com
We would much rather use ipmitool without patches rather than keep patches around that fix generic issues like this.

If other modules were affected, that would be a generic issue. But it
seems to me they're not. So I would say it's a 'lib/ipmi_delloem.c'
issue.

Post by D***@Emerson.com
What else is required to get these changes into ipmitool?

Re-write 'lib/ipmi_delloem.c' a bit, resp. change the way it handles argc/argv.

~~~
-static int current_arg = 0;
+int current_arg = 0;
~~~
And see whether it doesn't break normal operation of 'lib/ipmi_delloem.c' and whether it fixes your/reported issue as well.
That's the quickest/easiest fix that comes, resp. I had for some time, in my mind. I obviously haven't tried it, but I would (eventually).
Z.

Post by Zdenek Styblik
Best regards,
Z.

Post by D***@Emerson.com
Thanks,
Dick Detweiler

[Zdenek Styblik]

On Mon, Jul 8, 2013 at 12:06 PM, Zdenek Styblik

Post by Zdenek Styblik

Post by D***@Emerson.com
OK - will let you know what we find.
Thanks Z,
Richard Detweiler | T 256-261-6550

Hello Richard,
any progress on this one?
Thanks,
Z.

Scratch that.

Z.

Post by Zdenek Styblik

Post by D***@Emerson.com
-----Original Message-----
Sent: Wednesday, March 27, 2013 7:07 AM
To: Detweiler, Dick [NETPWR/AVOCENT/AL]
Subject: Re: [ ipmitool-Bugs-3571570 ] delloem exec file won't handle more than one command

Post by Zdenek Styblik

Post by D***@Emerson.com
Hi all,

Hello Dick,

Post by D***@Emerson.com
Styblik indicates via a comment yesterday that the patches I submitted last September for this issue will not be added to ipmitool saying " I'm afraid fix will be, well, complicated."

yep, that's what I said. However, I didn't say issue won't be fixed.

Post by D***@Emerson.com
I believe the patches I sent were a complete fix. We have been using them since September without issue.

Despite your patch does fix issue in question, there is no need to
"fix", or modify in any other way, 'src/ipmishell.c', because it isn't
broken. But 'lib/ipmi_delloem.c' apparently is.

Post by D***@Emerson.com
We would much rather use ipmitool without patches rather than keep patches around that fix generic issues like this.

If other modules were affected, that would be a generic issue. But it
seems to me they're not. So I would say it's a 'lib/ipmi_delloem.c'
issue.

Post by D***@Emerson.com
What else is required to get these changes into ipmitool?

Re-write 'lib/ipmi_delloem.c' a bit, resp. change the way it handles argc/argv.

~~~
-static int current_arg = 0;
+int current_arg = 0;
~~~
And see whether it doesn't break normal operation of 'lib/ipmi_delloem.c' and whether it fixes your/reported issue as well.
That's the quickest/easiest fix that comes, resp. I had for some time, in my mind. I obviously haven't tried it, but I would (eventually).
Z.

Post by Zdenek Styblik
Best regards,
Z.

Post by D***@Emerson.com
Thanks,
Dick Detweiler