[Ipmitool-devel] [RESEND] [PATCH] Return proper error value for Dell oem commands - easy and obvious fix

[Thomas Renninger]

From: Paul Zirnik <***@suse.de>

Signed-off-by: Thomas Renninger <***@suse.de>

diff --git a/lib/ipmi_delloem.c b/lib/ipmi_delloem.c
index d18e84a..2214c99 100644
--- a/lib/ipmi_delloem.c
+++ b/lib/ipmi_delloem.c
@@ -273,22 +273,22 @@ ipmi_delloem_main(struct ipmi_intf * intf, int argc, char ** argv)
return 0;
}
if (0 ==strncmp(argv[current_arg], "lcd\0", 4)) {
- ipmi_delloem_lcd_main(intf,argc,argv);
+ rc = ipmi_delloem_lcd_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "mac\0", 4) == 0) {
/* mac address*/
- ipmi_delloem_mac_main(intf,argc,argv);
+ rc = ipmi_delloem_mac_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "lan\0", 4) == 0) {
/* lan address*/
- ipmi_delloem_lan_main(intf,argc,argv);
+ rc = ipmi_delloem_lan_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "setled\0", 7) == 0) {
/* SetLED support */
- ipmi_delloem_setled_main(intf,argc,argv);
+ rc = ipmi_delloem_setled_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "powermonitor\0", 13) == 0) {
/*Powermanagement report processing*/
- ipmi_delloem_powermonitor_main(intf,argc,argv);
+ rc = ipmi_delloem_powermonitor_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "vFlash\0", 7) == 0) {
/* vFlash Support */
- ipmi_delloem_vFlash_main(intf,argc,argv);
+ rc = ipmi_delloem_vFlash_main(intf,argc,argv);
} else {
usage();
return -1;

[Thomas Renninger]

Hi,

below patch is a rebase from a patch I sent some months ago.
I didn't get any response, nor has this patch been applied.

I now have to maintain the patch in our latest distributions
and I would appreciate if it gets applied mainline or if someone
gives me a hint where to submit so that this happens.

Thanks,

Thomas

Post by Thomas Renninger
diff --git a/lib/ipmi_delloem.c b/lib/ipmi_delloem.c
index d18e84a..2214c99 100644
--- a/lib/ipmi_delloem.c
+++ b/lib/ipmi_delloem.c
@@ -273,22 +273,22 @@ ipmi_delloem_main(struct ipmi_intf * intf, int argc,
char ** argv) return 0;
}
if (0 ==strncmp(argv[current_arg], "lcd\0", 4)) {
- ipmi_delloem_lcd_main(intf,argc,argv);
+ rc = ipmi_delloem_lcd_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "mac\0", 4) == 0) {
/* mac address*/
- ipmi_delloem_mac_main(intf,argc,argv);
+ rc = ipmi_delloem_mac_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "lan\0", 4) == 0) {
/* lan address*/
- ipmi_delloem_lan_main(intf,argc,argv);
+ rc = ipmi_delloem_lan_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "setled\0", 7) == 0) {
/* SetLED support */
- ipmi_delloem_setled_main(intf,argc,argv);
+ rc = ipmi_delloem_setled_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "powermonitor\0", 13) == 0) {
/*Powermanagement report processing*/
- ipmi_delloem_powermonitor_main(intf,argc,argv);
+ rc = ipmi_delloem_powermonitor_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "vFlash\0", 7) == 0) {
/* vFlash Support */
- ipmi_delloem_vFlash_main(intf,argc,argv);
+ rc = ipmi_delloem_vFlash_main(intf,argc,argv);
} else {
usage();
return -1;

[Zdenek Styblik]

Post by Thomas Renninger
Hi,
below patch is a rebase from a patch I sent some months ago.
I didn't get any response, nor has this patch been applied.
I now have to maintain the patch in our latest distributions
and I would appreciate if it gets applied mainline or if someone
gives me a hint where to submit so that this happens.
Thanks,
Thomas

Hello,

I do see response there
https://sourceforge.net/p/ipmitool/source/merge-requests/1/

Best regards,
Z.

Post by Thomas Renninger

Post by Thomas Renninger
diff --git a/lib/ipmi_delloem.c b/lib/ipmi_delloem.c
index d18e84a..2214c99 100644
--- a/lib/ipmi_delloem.c
+++ b/lib/ipmi_delloem.c
@@ -273,22 +273,22 @@ ipmi_delloem_main(struct ipmi_intf * intf, int argc,
char ** argv) return 0;
}
if (0 ==strncmp(argv[current_arg], "lcd\0", 4)) {
- ipmi_delloem_lcd_main(intf,argc,argv);
+ rc = ipmi_delloem_lcd_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "mac\0", 4) == 0) {
/* mac address*/
- ipmi_delloem_mac_main(intf,argc,argv);
+ rc = ipmi_delloem_mac_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "lan\0", 4) == 0) {
/* lan address*/
- ipmi_delloem_lan_main(intf,argc,argv);
+ rc = ipmi_delloem_lan_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "setled\0", 7) == 0) {
/* SetLED support */
- ipmi_delloem_setled_main(intf,argc,argv);
+ rc = ipmi_delloem_setled_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "powermonitor\0", 13) == 0) {
/*Powermanagement report processing*/
- ipmi_delloem_powermonitor_main(intf,argc,argv);
+ rc = ipmi_delloem_powermonitor_main(intf,argc,argv);
} else if (strncmp(argv[current_arg], "vFlash\0", 7) == 0) {
/* vFlash Support */
- ipmi_delloem_vFlash_main(intf,argc,argv);
+ rc = ipmi_delloem_vFlash_main(intf,argc,argv);
} else {
usage();
return -1;

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ipmitool-devel mailing list
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

[Thomas Renninger]

Post by Zdenek Styblik

Post by Thomas Renninger
Hi,
below patch is a rebase from a patch I sent some months ago.
I didn't get any response, nor has this patch been applied.
I now have to maintain the patch in our latest distributions
and I would appreciate if it gets applied mainline or if someone
gives me a hint where to submit so that this happens.
Thanks,
Thomas

Hello,
I do see response there
https://sourceforge.net/p/ipmitool/source/merge-requests/1/

Hm, I do not know anymore how I submitted things previously, through
git pull or similar?

In my git tree the patch seem to exist:
git clone git://git.code.sf.net/u/watologo/ipmitool u-watologo-ipmitool
[2f5789] ipmitool delloem: ipmitool delloem extension ...

Anyway, in the public ipmitool master tree it still seem to miss.

Can you simply take this patch I sent to the ipmitool-devel mailinglist
some hours ago and you answered with this mail?

If not, please tell me what is your preferred way to submit patches.

Thanks,

Thomas