Discussion:
[Ipmitool-devel] [PATCH]ipmitool1.8.15 close console session for sol deactivate command
Mamatha Inamdar
2015-08-13 06:22:12 UTC
Permalink
In the new version of ipmitool 1.8.15, sol deactivate command was not closing the session,
This patch is to fix close console session When we issue sol deactivate command.

Signed-off-by: Mamatha Inamdar <***@linux.vnet.ibm.com>
---
lib/ipmi_sol.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/lib/ipmi_sol.c b/lib/ipmi_sol.c
index cf58b44..b497f46 100644
--- a/lib/ipmi_sol.c
+++ b/lib/ipmi_sol.c
@@ -1648,6 +1648,9 @@ ipmi_sol_red_pill(struct ipmi_intf * intf, int instance)
{
output(rs);
}
+ else
+ bShouldExit = bBmcClosedSession = 1;
+
/*
* Should recv_sol come back null, the incoming packet was not ours.
* Just fall through, the keepalive logic will determine if


------------------------------------------------------------------------------
Zdenek Styblik
2015-08-13 08:16:44 UTC
Permalink
On Thu, Aug 13, 2015 at 8:22 AM, Mamatha Inamdar
Post by Mamatha Inamdar
In the new version of ipmitool 1.8.15, sol deactivate command was not closing the session,
This patch is to fix close console session When we issue sol deactivate command.
Hello,

please, open ticket at sf.net and attach patch there.

Thanks.

Best regards,
Z.
Post by Mamatha Inamdar
---
lib/ipmi_sol.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/ipmi_sol.c b/lib/ipmi_sol.c
index cf58b44..b497f46 100644
--- a/lib/ipmi_sol.c
+++ b/lib/ipmi_sol.c
@@ -1648,6 +1648,9 @@ ipmi_sol_red_pill(struct ipmi_intf * intf, int instance)
{
output(rs);
}
+ else
+ bShouldExit = bBmcClosedSession = 1;
+
/*
* Should recv_sol come back null, the incoming packet was not ours.
* Just fall through, the keepalive logic will determine if
------------------------------------------------------------------------------
_______________________________________________
Ipmitool-devel mailing list
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------------
Mamatha Inamdar
2015-08-19 11:52:32 UTC
Permalink
I don't have access to create ticket in sf.net, let me know how do I get
the access?
Post by Zdenek Styblik
On Thu, Aug 13, 2015 at 8:22 AM, Mamatha Inamdar
Post by Mamatha Inamdar
In the new version of ipmitool 1.8.15, sol deactivate command was not closing the session,
This patch is to fix close console session When we issue sol deactivate command.
Hello,
please, open ticket at sf.net and attach patch there.
Thanks.
Best regards,
Z.
Post by Mamatha Inamdar
---
lib/ipmi_sol.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/ipmi_sol.c b/lib/ipmi_sol.c
index cf58b44..b497f46 100644
--- a/lib/ipmi_sol.c
+++ b/lib/ipmi_sol.c
@@ -1648,6 +1648,9 @@ ipmi_sol_red_pill(struct ipmi_intf * intf, int instance)
{
output(rs);
}
+ else
+ bShouldExit = bBmcClosedSession = 1;
+
/*
* Should recv_sol come back null, the incoming packet was not ours.
* Just fall through, the keepalive logic will determine if
------------------------------------------------------------------------------
_______________________________________________
Ipmitool-devel mailing list
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------------
Zdenek Styblik
2015-08-19 14:07:21 UTC
Permalink
On Wed, Aug 19, 2015 at 1:52 PM, Mamatha Inamdar
I don't have access to create ticket in sf.net, let me know how do I get the
access?
Mamatha,

create account, log in, create ticket at
http://sourceforge.net/p/ipmitool/bugs/?source=navbar . I believe you
already have an account since you're subscribed to this mailing list,
don't you?

Best regards,
Z.
Post by Zdenek Styblik
On Thu, Aug 13, 2015 at 8:22 AM, Mamatha Inamdar
Post by Mamatha Inamdar
In the new version of ipmitool 1.8.15, sol deactivate command was not
closing the session,
This patch is to fix close console session When we issue sol deactivate command.
Hello,
please, open ticket at sf.net and attach patch there.
Thanks.
Best regards,
Z.
Post by Mamatha Inamdar
---
lib/ipmi_sol.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/ipmi_sol.c b/lib/ipmi_sol.c
index cf58b44..b497f46 100644
--- a/lib/ipmi_sol.c
+++ b/lib/ipmi_sol.c
@@ -1648,6 +1648,9 @@ ipmi_sol_red_pill(struct ipmi_intf * intf, int instance)
{
output(rs);
}
+ else
+ bShouldExit = bBmcClosedSession = 1;
+
/*
* Should recv_sol come back null, the
incoming packet was not ours.
* Just fall through, the keepalive
logic will determine if
------------------------------------------------------------------------------
_______________________________________________
Ipmitool-devel mailing list
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------------
Loading...