On Tue, Apr 1, 2014 at 4:10 PM, Liebig, Holger
Post by Liebig, Holger[Liebig, Holger]
This reminded me that I never got back with the DCMI issues I reported some time ago just before the 1.813 release. The current code does not allow to specify a DCMI power limit action (e.g. 'ipmitool dcmi power set_limit action power_off' will not work since this is parsed as integer with the str2uint() construct in line 1459). The attached patch proposal fixes this as well as allowing 'no_action' and any oem actions (if supported by the BMC).
Let me know if I need to file an additional bug report / patch proposal (there seems to be 2 already open as 144 / 291)
Best Regards,
Holger Liebig
Holger,
I gave it a commit. Two things I know won't happen, but I will say it
anyway(and probably even repeat myself):
1] man page update - I guess it's necessary, at least in case of
proposed patch in Bug#291 was
2] I would be lovely if one of you lot would rewrite 'lib/ipmi_dcmi.c'.
I just hope this got fixed.
Jim, please, cut rc2. I have nothing else to commit for 1.8.14, so
unless there are serious issues with rc2, I'm ok with release.
Thanks and regards,
Z.
Post by Liebig, Holger---------- Forwarded message ----------
Date: Mon, 9 Sep 2013 19:40:14 +0200
Subject: Re: [Ipmitool-devel] Code Review: ID: 212 - 'lib/ipmi_dcmi.c' - possible int *flow
On Mon, Sep 9, 2013 at 5:14 PM, Liebig, Holger
Post by Liebig, Holger[Liebig, Holger]
unfortunately the change breaks 'ipmitool dcmi power set_limit action power_off' due to the test for a valid integer value at the beginning of the ipmi_dcmi_pwr_slimit() function which should be valid only for the numeric options.
Also, the dcmi_pwrmgmt_action_vals array has only the long description strings and no value strings, so the above command would still fail without additional work and last but not least, 'no_action' cannot be specified.
Since the window for the 1.8.13 is most likely closed, these should be documented as limitations/known bugs somewhere. I will provide a patch proposal, but would like to check the other stuff as well before sending it.
Holger
I can't come up with anything else, but ... funny, very funny.
Best regards,
Z.
------------------------------------------------------------------------------
_______________________________________________
Ipmitool-devel mailing list
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel