[Ipmitool-devel] [Patch] Fix SPD size decoding

[Amelkin, Aleksandr]

Hi.

We found that 'ipmitool spd' incorrectly decodes SPD information regarding the module size.
Specifically, for our Micron 18HTF25672PKZ80-EH1 DDR2 modules it reported 338MB size instead of 2048MB.

The attached patch replaces the size decoding code with that from "decode-dimms" perl script found in i2c-tools 3.0.3.

The patch is against the official ipmitool 1.8.13.

Please review.

With best regards -
Alexander Amelkin,
Head of Embedded Software Division,
R&D Department, T-Platforms
http://www.t-platforms.com
Tel.: [phone], ext. 1086

[Amelkin, Aleksandr]

I've posted a patch three weeks ago with no reaction whatsoever.
Is there anything wrong with the format of my post or is it just that the patch processing queue is full?
I would highly appreciate any reaction. :)

Alexander.

From: Amelkin, Aleksandr [mailto:***@t-platforms.ru]
Sent: Wednesday, March 05, 2014 6:00 PM
To: ipmitool-***@lists.sourceforge.net
Subject: [Ipmitool-devel] [Patch] Fix SPD size decoding

Hi.

We found that 'ipmitool spd' incorrectly decodes SPD information regarding the module size.
Specifically, for our Micron 18HTF25672PKZ80-EH1 DDR2 modules it reported 338MB size instead of 2048MB.

The attached patch replaces the size decoding code with that from "decode-dimms" perl script found in i2c-tools 3.0.3.

The patch is against the official ipmitool 1.8.13.

Please review.

With best regards -
Alexander Amelkin,
Head of Embedded Software Division,
R&D Department, T-Platforms
http://www.t-platforms.com
Tel.: [phone], ext. 1086

[Zdenek Styblik]

On Mon, Mar 24, 2014 at 12:45 PM, Amelkin, Aleksandr
<***@t-platforms.ru> wrote:
> I’ve posted a patch three weeks ago with no reaction whatsoever.
>
> Is there anything wrong with the format of my post or is it just that the
> patch processing queue is full?
>
> I would highly appreciate any reaction. J
>

Do you mean the one I've committed yesterday? ;)
Please, open a ticket next time, it will be a time-saver and you might
see some progress on the state of the ticket as well.

Thanks,
Z.

PS: processing queue is always full.

>
>
> Alexander.
>
>
>
> From: Amelkin, Aleksandr [mailto:***@t-platforms.ru]
> Sent: Wednesday, March 05, 2014 6:00 PM
> To: ipmitool-***@lists.sourceforge.net
> Subject: [Ipmitool-devel] [Patch] Fix SPD size decoding
>
>
>
> Hi.
>
>
>
> We found that ‘ipmitool spd’ incorrectly decodes SPD information regarding
> the module size.
>
> Specifically, for our Micron 18HTF25672PKZ80-EH1 DDR2 modules it reported
> 338MB size instead of 2048MB.
>
>
>
> The attached patch replaces the size decoding code with that from
> “decode-dimms” perl script found in i2c-tools 3.0.3.
>
>
>
> The patch is against the official ipmitool 1.8.13.
>
>
>
> Please review.
>
>
>
> With best regards –
>
> Alexander Amelkin,
>
> Head of Embedded Software Division,
>
> R&D Department, T-Platforms
>
> http://www.t-platforms.com
>
> Tel.: [phone], ext. 1086
>
>
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/13534_NeoTech
> _______________________________________________
> Ipmitool-devel mailing list
> Ipmitool-***@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>

[Amelkin, Aleksandr]

Oh, thank you!

Will open a ticket next time.

Alexander.
________________________________________
От: Zdenek Styblik [***@gmail.com]
Отправлено: 24 марта 2014 г. 16:20
Кому: Amelkin, Aleksandr
Копия: ipmitool-***@lists.sourceforge.net
Тема: Re: [Ipmitool-devel] [Patch] Fix SPD size decoding

On Mon, Mar 24, 2014 at 12:45 PM, Amelkin, Aleksandr
<***@t-platforms.ru> wrote:
> I’ve posted a patch three weeks ago with no reaction whatsoever.
>
> Is there anything wrong with the format of my post or is it just that the
> patch processing queue is full?
>
> I would highly appreciate any reaction. J
>

Do you mean the one I've committed yesterday? ;)
Please, open a ticket next time, it will be a time-saver and you might
see some progress on the state of the ticket as well.

Thanks,
Z.

PS: processing queue is always full.

>
>
> Alexander.
>
>
>
> From: Amelkin, Aleksandr [mailto:***@t-platforms.ru]
> Sent: Wednesday, March 05, 2014 6:00 PM
> To: ipmitool-***@lists.sourceforge.net
> Subject: [Ipmitool-devel] [Patch] Fix SPD size decoding
>
>
>
> Hi.
>
>
>
> We found that ‘ipmitool spd’ incorrectly decodes SPD information regarding
> the module size.
>
> Specifically, for our Micron 18HTF25672PKZ80-EH1 DDR2 modules it reported
> 338MB size instead of 2048MB.
>
>
>
> The attached patch replaces the size decoding code with that from
> “decode-dimms” perl script found in i2c-tools 3.0.3.
>
>
>
> The patch is against the official ipmitool 1.8.13.
>
>
>
> Please review.
>
>
>
> With best regards –
>
> Alexander Amelkin,
>
> Head of Embedded Software Division,
>
> R&D Department, T-Platforms
>
> http://www.t-platforms.com
>
> Tel.: [phone], ext. 1086
>
>
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/13534_NeoTech
> _______________________________________________
> Ipmitool-devel mailing list
> Ipmitool-***@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>