[Ipmitool-devel] Fwd: [ipmitool:patches] #74 Improve help message for 'ipmitool picmg policy set'

[Dan Gora]

[patches:#74] Improve help message for 'ipmitool picmg policy set'

Status: open
Created: Tue Aug 06, 2013 09:26 PM UTC by Dan Gora
Last Updated: Tue Aug 06, 2013 09:26 PM UTC
Owner: nobody

A quick patch to improve the help message for ipmitool picmg policy
set. The previous help message was basically just copied out of the
AMC specifications describing the bit fields in the message, but it
was really unclear how the command itself worked without looking at
the source code and the AMC specification. It now tries to make it
clear that the values in square brackets are bit positions and not
values.

thanks
dan

Index: lib/ipmi_picmg.c

RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_picmg.c,v
retrieving revision 1.26

diff -u -r1.26 ipmi_picmg.c
--- lib/ipmi_picmg.c 18 May 2013 06:31:02 -0000 1.26
+++ lib/ipmi_picmg.c 6 Aug 2013 21:22:21 -0000
@@ -1858,12 +1858,13 @@
} else {
lprintf(LOG_NOTICE, "usage: set ");
lprintf(LOG_NOTICE,
- " lockmask: [1] affect the deactivation locked bit");
+ " lockmask: [bit 1] Set to 1 to affect the deactivation locked bit");
lprintf(LOG_NOTICE,
- " [0] affect the activation locked bit");
+ " [bit 0] Set to 1 to affect the activation locked bit");
lprintf(LOG_NOTICE,
- " lock: [1] set/clear deactivation locked");
- lprintf(LOG_NOTICE, " [0] set/clear locked");
+ " lock: [bit 1] Set to 1 to set, 0 to clear deactivation locked");
+ lprintf(LOG_NOTICE,
+ " [bit 0] Set to 1 to set, 0 to clear activation locked");
}
}
else {

________________________________

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/ipmitool/patches/74/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/
--
Dan Gora
Software Engineer

Adax, Inc.
Av Dona Maria Alves, 1070 Casa 5
Centro
Ubatuba, SP
CEP 11680-000
Brasil

Tel: [phone] (Brazil and outside of US)
: [phone] (Inside of US)
: dan_gora (Skype)

email: ***@adax.com