Zdenek Styblik
2013-05-06 10:18:47 UTC
Hi all,
attached is a diff which replaces atoi()/strto*() calls in
'lib/ipmi_picmg.c' either with wrapper functions or str2*() calls.
Also, range limits are being applied to input values and it should be
possible to input hex/octal values now(ID#3611253).
Note, however, comments in diff need a clean-up and there is a lack of
documentation now. But it will be there for the finals.
Now, I've used Emerson's AMC specification[1] for limits. However, I'm
not sure nor convinced whether it's PICMG/AMC specification or just
Emerson specification/implementation. I couldn't find any PICMG
limits, resp. IPMI-PICMG specification, though. If somebody has
real-life experience with PICMG and knows what values, resp. what
range of values is expected, please, let me know. Eg. values for
Device ID, Port and Interface aren't being checked beyond whether it's
some kind of integer. I don't know what limits should apply here,
because I couldn't find any.
Thanks,
Z.
[1] http://www.emersonnetworkpower.com/en-US/Products/EmbeddedComputing/Documents/DocumentationArchive/TechnicalDocumentation/01/6806800G28B_AMC9210_IPMI_PR.pdf
attached is a diff which replaces atoi()/strto*() calls in
'lib/ipmi_picmg.c' either with wrapper functions or str2*() calls.
Also, range limits are being applied to input values and it should be
possible to input hex/octal values now(ID#3611253).
Note, however, comments in diff need a clean-up and there is a lack of
documentation now. But it will be there for the finals.
Now, I've used Emerson's AMC specification[1] for limits. However, I'm
not sure nor convinced whether it's PICMG/AMC specification or just
Emerson specification/implementation. I couldn't find any PICMG
limits, resp. IPMI-PICMG specification, though. If somebody has
real-life experience with PICMG and knows what values, resp. what
range of values is expected, please, let me know. Eg. values for
Device ID, Port and Interface aren't being checked beyond whether it's
some kind of integer. I don't know what limits should apply here,
because I couldn't find any.
Thanks,
Z.
[1] http://www.emersonnetworkpower.com/en-US/Products/EmbeddedComputing/Documents/DocumentationArchive/TechnicalDocumentation/01/6806800G28B_AMC9210_IPMI_PR.pdf